Introduce pydantic_v1 compatibility module for pydantic>=2.0.0 support #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of upgrading deepspeed to pydantic v2, deepspeed can use pydantic v2's alias for the v1 API in order to unpin pydantic and allow greater flexibility for deepspeed users
|
@microsoft-github-policy-service agree company="Protopia AI" |
mrwyattii
requested review from
jeffra,
tjruwase,
samyam,
mrwyattii,
RezaYazdaniAminabadi,
awan-10,
cmikeh2 and
arashb
as code owners
mrwyattii
approved these changes
Oct 9, 2023
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Oct 9, 2023
microsoft#4407) * Introduce pydantic_v1 compatibility module for pydantic>=2.0.0 support
|
@mrwyattii thank you so much for reviewing and merging! Can you release a patch including this PR? |
1 task
baodii
pushed a commit
to baodii/DeepSpeed
that referenced
this pull request
Nov 7, 2023
microsoft#4407) * Introduce pydantic_v1 compatibility module for pydantic>=2.0.0 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate to #3902
Related: microsoft/DeepSpeed-MII#240
Inspired by LangChain's solution: https://github.com/langchain-ai/langchain/blob/64385c4eae4a4b8c27e73b09018f344f0b791f31/libs/langchain/langchain/pydantic_v1/__init__.py#L14-L17
deepspeedcan unpinpydantic, but instead of using the newpydanticv2 features,deepspeedcan use v2's alias for the v1 API in order to allow greater flexibility fordeepspeedusers by allowing them to use eitherpydanticv1 or v2