Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add position_ids arg to OPTEmbedding forward function #6939

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Add position_ids arg to OPTEmbedding forward function #6939

merged 2 commits into from
Jan 9, 2025

Conversation

lekurile
Copy link
Contributor

@lekurile lekurile commented Jan 9, 2025

This PR updates the DeepSpeed OPTEmbedding forward function to include a new positions_ids argument.

@loadams loadams mentioned this pull request Jan 9, 2025
Closed
@loadams loadams enabled auto-merge January 9, 2025 19:27
@loadams loadams added this pull request to the merge queue Jan 9, 2025
Merged via the queue into master with commit 0fc3daa Jan 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loadams loadams loadams approved these changes

@hwchen2017 hwchen2017 Awaiting requested review from hwchen2017 hwchen2017 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lekurile @loadams