[spirv] do not round size of last row vector for dx layout #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matrix size rules for cbuffers/tbuffers do not match those of fxc with -fvk-use-dx-layout enabled. The size of the last row should not be rounded to the alignment size in order to maintain DirectX consistency. This non-rounding scheme passes the SPIR-V validator, but *only* in (GLSL) row-major layout. Column-major behavior is unaltered. The relevant validator check is here: https://github.com/KhronosGroup/SPIRV-Tools/blob/e70b009b0f1e47278d89ed7c9f418010d563eb5a/source/val/validate_decorations.cpp#L309-L317
|
|
|
Thank you for sending this PR. I will take a look. |
|
On a related note, I am not entirely sure how to handle (HLSL) row major matrices. They also do not round up the last vector, but that must happen in order to pass SPIR-V validation. Should a warning indicating DX incompatibility be emitted in this case? |
|
I am really sorry for being late. Your PR looks good, but addressing your questions might be difficult. I have no idea whether we will just allow GLSL column major behavior even though it results in validation error or just do not handle the case of GLSL column major. Let me take some time to discuss this issue. |
|
#3672 fixes this issue. Let me close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matrix size rules for cbuffers/tbuffers do not match those of fxc
with -fvk-use-dx-layout enabled. The size of the last row should not be
rounded to the alignment size in order to maintain DirectX consistency.
This non-rounding scheme passes the SPIR-V validator, but only in
(GLSL) row-major layout. Column-major behavior is unaltered.
The relevant validator check is here:
https://github.com/KhronosGroup/SPIRV-Tools/blob/e70b009b0f1e47278d89ed7c9f418010d563eb5a/source/val/validate_decorations.cpp#L309-L317