Gangams/extend arc k8s msi arm templates for ampls #1192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
arc-k8s-extension-msi-auth/existingClusterOnboarding.json
andarc-k8s-extension-msi-auth/existingClusterParam.json
scripts, primarily adding functionality for Azure Monitor Private Link Scope. The most significant changes include the addition of new parameters and variables, conditional logic for using Azure Monitor Private Link Scope, and new resources and deployments related to the Private Link Scope.Addition of new parameters and variables:
existingClusterOnboarding.json
: AddeduseAzureMonitorPrivateLinkScope
andazureMonitorPrivateLinkScopeResourceId
parameters to indicate if Azure Monitor Private Link Scope should be used and to specify its Resource Id. Also added several variables related to the workspace and data collection endpoint.Conditional logic for Azure Monitor Private Link Scope:
existingClusterOnboarding.json
: Added conditional logic fordataCollectionEndpointId
and new resources and deployments, which are only created ifuseAzureMonitorPrivateLinkScope
is true. [1] [2] [3]Addition of new resources and deployments:
existingClusterOnboarding.json
: Added new resources of typeMicrosoft.Insights/dataCollectionEndpoints
and new deployments for data collection rule endpoint association and Azure Monitor Private Link Scope scoped resources. These are only created ifuseAzureMonitorPrivateLinkScope
is true. [1] [2]Changes to existing resources:
existingClusterOnboarding.json
: Modified the description property in the properties of the existing resource of typeMicrosoft.ContainerService/managedClusters/providers/dataCollectionRuleAssociations
.Changes to parameter file:
existingClusterParam.json
: AddeduseAzureMonitorPrivateLinkScope
andazureMonitorPrivateLinkScopeResourceId
parameters.