Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gangams/extend arc k8s msi arm templates for ampls #1192

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

ganga1980
Copy link
Contributor

This pull request includes changes to the arc-k8s-extension-msi-auth/existingClusterOnboarding.json and arc-k8s-extension-msi-auth/existingClusterParam.json scripts, primarily adding functionality for Azure Monitor Private Link Scope. The most significant changes include the addition of new parameters and variables, conditional logic for using Azure Monitor Private Link Scope, and new resources and deployments related to the Private Link Scope.

Addition of new parameters and variables:

  • existingClusterOnboarding.json: Added useAzureMonitorPrivateLinkScope and azureMonitorPrivateLinkScopeResourceId parameters to indicate if Azure Monitor Private Link Scope should be used and to specify its Resource Id. Also added several variables related to the workspace and data collection endpoint.

Conditional logic for Azure Monitor Private Link Scope:

  • existingClusterOnboarding.json: Added conditional logic for dataCollectionEndpointId and new resources and deployments, which are only created if useAzureMonitorPrivateLinkScope is true. [1] [2] [3]

Addition of new resources and deployments:

  • existingClusterOnboarding.json: Added new resources of type Microsoft.Insights/dataCollectionEndpoints and new deployments for data collection rule endpoint association and Azure Monitor Private Link Scope scoped resources. These are only created if useAzureMonitorPrivateLinkScope is true. [1] [2]

Changes to existing resources:

  • existingClusterOnboarding.json: Modified the description property in the properties of the existing resource of type Microsoft.ContainerService/managedClusters/providers/dataCollectionRuleAssociations.

Changes to parameter file:

@ganga1980 ganga1980 requested a review from a team as a code owner March 4, 2024 06:08
pfrcks
pfrcks previously approved these changes Mar 4, 2024
wanlonghenry
wanlonghenry previously approved these changes Mar 4, 2024
@ganga1980 ganga1980 dismissed stale reviews from wanlonghenry and pfrcks via a11cf85 March 5, 2024 06:02
@ganga1980 ganga1980 enabled auto-merge (squash) March 5, 2024 17:13
@ganga1980 ganga1980 merged commit 59391b4 into ci_prod Mar 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants