enable syslog collection for cosmic #1282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request mainly focuses on improving the logging and security aspects of the codebase. The most significant changes include the addition of new CVEs to the
.trivyignore
file, modifications to thelivenessprobe.sh
script that improve the handling of syslog status, and updates to theama-logs.yaml
andmain.sh
files in thekubernetes
directory that enhance the configuration of the logging system.Security improvements:
.trivyignore
: Added new CVEs (CVE-2024-24790
andCVE-2024-24789
) to the ignore list. This is a security measure to prevent the system from being affected by these vulnerabilities.Logging improvements:
build/linux/installer/scripts/livenessprobe.sh
: The conditional logic for handling the syslog status has been revised. The new code checks if theCONTROLLER_TYPE
is aDaemonSet
and then handles the syslog status differently based on theCONTAINER_TYPE
andGENEVA_LOGS_INTEGRATION
values. [1] [2]kubernetes/ama-logs.yaml
: AddedSYSLOG_HOST_PORT
to the environment variables and a new mount path. These changes provide additional configuration options for the logging system. [1] [2]kubernetes/linux/main.sh
: Various changes have been made to handle different scenarios based on theCONTAINER_TYPE
,GENEVA_LOGS_INTEGRATION
, andSYSLOG_HOST_PORT
values. These changes improve the flexibility of the logging system and its integration with other services. [1] [2] [3] [4]