Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display latency info for API calls #101

Merged
merged 5 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ namespace Contoso.FraudProtection.ApplicationCore.Entities.FraudProtectionApiMod
public class SampleResponseRaw
{
public object RawData { get; set; }

public long ResponseTime { get; set; }
}

public class SampleResponse<T> : SampleResponseRaw
Expand Down
45 changes: 18 additions & 27 deletions src/Infrastructure/Services/FraudProtectionService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,12 @@ private async Task<HttpResponseMessage> PostAsync<T>(
});
}

private async Task<SampleResponse<T>> Read<T>(HttpResponseMessage response) where T : new()
private async Task<SampleResponse<T>> CallAndRead<T>(Func<Task<HttpResponseMessage>> apiCall) where T : new()
{
var watch = System.Diagnostics.Stopwatch.StartNew();
var response = await apiCall();
watch.Stop();

if (!response.IsSuccessStatusCode)
{
throw new FraudProtectionApiException(response);
Expand All @@ -104,87 +108,74 @@ private async Task<HttpResponseMessage> PostAsync<T>(
{
Data = JsonSerializer.Deserialize<T>(content, _responseDeserializationOptions),
RawData = JsonSerializer.Deserialize<object>(content, _responseDeserializationOptions),
ResponseTime = watch.ElapsedMilliseconds,
};
}

public async Task<SampleResponse<PurchaseResponse>> PostPurchase(Purchase purchase, string correlationId, string envId)
{
var response = await PostAsync(_settings.Endpoints.Purchase, purchase, correlationId, envId);
return await Read<PurchaseResponse>(response);
return await CallAndRead<PurchaseResponse>(() => PostAsync(_settings.Endpoints.Purchase, purchase, correlationId, envId));
}

public async Task<SampleResponse<FraudProtectionResponse>> PostRefund(Refund refund, string correlationId, string envId)
{
var response = await PostAsync(_settings.Endpoints.Refund, refund, correlationId, envId);
return await Read<FraudProtectionResponse>(response);
return await CallAndRead<FraudProtectionResponse>(() => PostAsync(_settings.Endpoints.Refund, refund, correlationId, envId));
}

public async Task<SampleResponse<FraudProtectionResponse>> PostUser(User userAccount, string correlationId, string envId)
{
var response = await PostAsync(_settings.Endpoints.UpdateAccount, userAccount, correlationId, envId);
return await Read<FraudProtectionResponse>(response);
return await CallAndRead<FraudProtectionResponse>(() => PostAsync(_settings.Endpoints.UpdateAccount, userAccount, correlationId, envId));
}

public async Task<SampleResponse<FraudProtectionResponse>> PostBankEvent(BankEvent bankEvent, string correlationId, string envId)
{
var response = await PostAsync(_settings.Endpoints.BankEvent, bankEvent, correlationId, envId);
return await Read<FraudProtectionResponse>(response);
return await CallAndRead<FraudProtectionResponse>(() => PostAsync(_settings.Endpoints.BankEvent, bankEvent, correlationId, envId));
}

public async Task<SampleResponse<FraudProtectionResponse>> PostChargeback(Chargeback chargeback, string correlationId, string envId)
{
var response = await PostAsync(_settings.Endpoints.Chargeback, chargeback, correlationId, envId);
return await Read<FraudProtectionResponse>(response);
return await CallAndRead<FraudProtectionResponse>(() => PostAsync(_settings.Endpoints.Chargeback, chargeback, correlationId, envId));
}

public async Task<SampleResponse<FraudProtectionResponse>> PostPurchaseStatus(PurchaseStatusEvent purchaseStatus, string correlationId, string envId)
{
var response = await PostAsync(_settings.Endpoints.PurchaseStatus, purchaseStatus, correlationId, envId);
return await Read<FraudProtectionResponse>(response);
return await CallAndRead<FraudProtectionResponse>(() => PostAsync(_settings.Endpoints.PurchaseStatus, purchaseStatus, correlationId, envId));
}

public async Task<SampleResponse<Response>> PostSignup(AccountProtection.SignUp signup, string correlationId, string envId)
{
var endpoint = string.Format(_settings.Endpoints.SignupAP, signup.Metadata.SignUpId);

var response = await PostAsync(endpoint, signup, correlationId, envId);
return await Read<Response>(response);
return await CallAndRead<Response>(() => PostAsync(endpoint, signup, correlationId, envId));
}

public async Task<SampleResponse<FraudProtectionResponse>> PostSignupStatus(SignupStatusEvent signupStatus, string correlationId, string envId)
{
var response = await PostAsync(_settings.Endpoints.SignupStatus, signupStatus, correlationId, envId);
return await Read<FraudProtectionResponse>(response);
return await CallAndRead<FraudProtectionResponse>(() => PostAsync(_settings.Endpoints.SignupStatus, signupStatus, correlationId, envId));
}

public async Task<SampleResponse<FraudProtectionResponse>> PostLabel(Label label, string correlationId, string envId)
{
var response = await PostAsync(_settings.Endpoints.Label, label, correlationId, envId);
return await Read<FraudProtectionResponse>(response);
return await CallAndRead<FraudProtectionResponse>(() => PostAsync(_settings.Endpoints.Label, label, correlationId, envId));
}

public async Task<SampleResponse<Response>> PostSignIn(AccountProtection.SignIn signIn, string correlationId, string envId)
{
var endpoint = string.Format(_settings.Endpoints.SignInAP, signIn.Metadata.LoginId);

var response = await PostAsync(endpoint, signIn, correlationId, envId);
return await Read<Response>(response);
return await CallAndRead<Response>(() => PostAsync(endpoint, signIn, correlationId, envId));
}

public async Task<SampleResponse<Response>> PostCustomAssessment(CustomAssessment assessment, string correlationId, string envId)
{
var endpoint = string.Format(_settings.Endpoints.CustomAssessment, assessment.ApiName);

var response = await PostAsync(endpoint, assessment.Payload, correlationId, envId, true);
return await Read<Response>(response);
return await CallAndRead<Response>(() => PostAsync(endpoint, assessment.Payload, correlationId, envId, true));
}

public async Task<SampleResponse<AssessmentResponse>> PostAssessment(CustomAssessment assessment, string correlationId, string envId)
{
var endpoint = string.Format(_settings.Endpoints.Assessment, assessment.ApiName);

var response = await PostAsync(endpoint, assessment.Payload, correlationId, envId, true);
return await Read<AssessmentResponse>(response);
return await CallAndRead<AssessmentResponse>(() => PostAsync(endpoint, assessment.Payload, correlationId, envId, true));
}
}
#endregion
Expand Down
4 changes: 3 additions & 1 deletion src/Web/ViewModels/FraudProtectionIOModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ public void Add(object request, SampleResponseRaw response, string name = "", bo
{
Request = skipSerialization ? request as string : JsonSerializer.Serialize(request, JsonSerializerOptions),
Response = JsonSerializer.Serialize(response.RawData, JsonSerializerOptions),
Name = name
Name = name,
ResponseTime = response.ResponseTime
});
}
}
Expand All @@ -47,5 +48,6 @@ public class RequestResponsePair
public string Request { get; set; }
public string Response { get; set; }
public string Name { get; set; }
public long ResponseTime { get; set; }
}
}
2 changes: 2 additions & 0 deletions src/Web/Views/Shared/_FraudProtectionIO.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
<div class="col-md-12">
<section>
@if (io.Name != null) { <h3>@io.Name</h3> }
@if (@io.ResponseTime > 0) { <h5>API call duration: @io.ResponseTime ms</h5> }
<div class="col-md-6">
<h4>Fraud Protection Request</h4>
<pre>@io.Request</pre>
Expand All @@ -35,6 +36,7 @@
</div>
</section>
</div>

</div>
</div>
}
Expand Down
Loading