Skip to content

Commit

Permalink
[main > v2int/1.2] build: Pass build-tools version correctly (#12534)
Browse files Browse the repository at this point in the history
Cherry-pick of #12485 to the v2int/1.2 release branch.
  • Loading branch information
tylerbutler authored Oct 18, 2022
1 parent 428700b commit 04404bf
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions tools/pipelines/templates/build-docker-service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ stages:
parameters:
buildDirectory: ${{ parameters.buildDirectory }}
buildNumberInPatch: ${{ parameters.buildNumberInPatch }}
buildToolsVersionToInstall: ${{ parameters.buildToolsVersionToInstall }}
tagName: ${{ parameters.tagName }}
- ${{ if eq(parameters.setVersion, false) }}:
- task: Bash@3
Expand Down
1 change: 1 addition & 0 deletions tools/pipelines/templates/build-npm-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ stages:
parameters:
buildDirectory: ${{ parameters.buildDirectory }}
buildNumberInPatch: ${{ parameters.buildNumberInPatch }}
buildToolsVersionToInstall: ${{ parameters.buildToolsVersionToInstall }}
tagName: ${{ parameters.tagName }}

# Build
Expand Down
1 change: 1 addition & 0 deletions tools/pipelines/templates/include-set-package-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ steps:
targetType: 'inline'
workingDirectory: ${{ parameters.buildDirectory }}
script: |
echo "${{ parameters.buildToolsVersionToInstall }}"
npm install --global "@fluid-tools/build-cli@${{ parameters.buildToolsVersionToInstall }}"
- task: Bash@3
Expand Down
5 changes: 5 additions & 0 deletions tools/pipelines/test-perf-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ parameters:
type: string
default: client

- name: buildToolsVersionToInstall
type: string
default: repo

variables:
# We use 'chalk' to colorize output, which auto-detects color support in the
# running terminal. The log output shown in Azure DevOps job runs only has
Expand Down Expand Up @@ -107,6 +111,7 @@ stages:
parameters:
buildDirectory: ${{ variables.buildDirectory }}
buildNumberInPatch: ${{ parameters.buildNumberInPatch }}
buildToolsVersionToInstall: ${{ parameters.buildToolsVersionToInstall }}
tagName: ${{ parameters.tagName }}

# Build
Expand Down

0 comments on commit 04404bf

Please sign in to comment.