Skip to content

Commit

Permalink
Revert exclusion of dist/lib from autoimport paths (#22376)
Browse files Browse the repository at this point in the history
## Description

These two exclusions cause imports to dependent packages to fail,
evidently since VSCode considers the 'correct' import paths for JS in
dist/lib to still be included.

Net effect here is we get import paths back, but the correct one needs
to be selected:


![image](https://github.com/user-attachments/assets/93834c88-bb6f-4054-a6d8-03a79df73324)

Further investigation in this space would be nice, but while that
happens the experience of having too many autoimports is preferable to
having none.

Co-authored-by: Abram Sanderson <[email protected]>
  • Loading branch information
Abe27342 and Abram Sanderson authored Sep 4, 2024
1 parent 72b0148 commit b2deac2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
// We prefer to use type-only imports, so we want the autoimporter to do that by default.
"typescript.preferences.preferTypeOnlyAutoImports": true,
"typescript.preferences.autoImportFileExcludePatterns": [
"**/dist/**",
"**/lib/**",
// Avoid suggesting autoimports for the 'previous' version packages which are used for typetesting.
"**/node_modules/**/@fluid*/*-previous",
"**/node_modules/**/@fluid*/*-previous/*",
Expand Down
2 changes: 0 additions & 2 deletions packages/dds/tree/.vscode/Tree.code-workspace
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
"settings": {
"search.followSymlinks": false,
"typescript.preferences.autoImportFileExcludePatterns": [
"**/dist/**",
"**/lib/**",
// Avoid suggesting autoimports for the 'previous' version packages which are used for typetesting.
"**/node_modules/**/@fluid*/*-previous",
"**/node_modules/**/@fluid*/*-previous/*"
Expand Down

0 comments on commit b2deac2

Please sign in to comment.