Skip to content

Commit

Permalink
Add telemetry related to seq numbers in deltamanager (#7585) (#7595)
Browse files Browse the repository at this point in the history
  • Loading branch information
jatgarg authored Sep 27, 2021
1 parent 6cbca05 commit d5b66f5
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 2 deletions.
4 changes: 4 additions & 0 deletions api-report/container-loader.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ export class DeltaManager extends TypedEventEmitter<IDeltaManagerInternalEvents>
// (undocumented)
get lastMessage(): ISequencedDocumentMessage | undefined;
// (undocumented)
get lastObservedSequenceNumber(): number;
// (undocumented)
get lastQueuedSeqNumber(): number;
// (undocumented)
get lastSequenceNumber(): number;
logConnectionIssue(event: ITelemetryErrorEvent): void;
// (undocumented)
Expand Down
3 changes: 3 additions & 0 deletions packages/loader/container-loader/src/container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,9 @@ export class Container extends EventEmitterWithErrorHandling<IContainerEvents> i
// load information to associate errors with the specific load point
dmInitialSeqNumber: () => this._deltaManager?.initialSequenceNumber,
dmLastKnownSeqNumber: () => this._deltaManager?.lastKnownSeqNumber,
dmLastProcessedSeqNumber: () => this._deltaManager?.lastSequenceNumber,
dmLastQueuedSeqNumber: () => this._deltaManager?.lastQueuedSeqNumber,
dmLastObservedSeqNumber: () => this._deltaManager?.lastObservedSequenceNumber,
containerLoadedFromVersionId: () => this.loadedFromVersion?.id,
containerLoadedFromVersionDate: () => this.loadedFromVersion?.date,
// message information to associate errors with the specific execution state
Expand Down
18 changes: 16 additions & 2 deletions packages/loader/container-loader/src/deltaManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,14 @@ export class DeltaManager
return this.initSequenceNumber;
}

public get lastQueuedSeqNumber(): number {
return this.lastQueuedSequenceNumber;
}

public get lastObservedSequenceNumber(): number {
return this.lastObservedSeqNumber;
}

public get lastSequenceNumber(): number {
return this.lastProcessedSequenceNumber;
}
Expand Down Expand Up @@ -1539,8 +1547,8 @@ export class DeltaManager
* Retrieves the missing deltas between the given sequence numbers
*/
private fetchMissingDeltas(reasonArg: string, lastKnowOp: number, to?: number) {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.fetchMissingDeltasCore(reasonArg, false /* cacheOnly */, lastKnowOp, to);
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.fetchMissingDeltasCore(reasonArg, false /* cacheOnly */, lastKnowOp, to);
}

/**
Expand All @@ -1562,6 +1570,12 @@ export class DeltaManager
return;
}

this.logger.sendTelemetryEvent({
eventName: "fetchingDeltas",
fetchReason: reason,
lastKnowOp,
to,
});
try {
assert(lastKnowOp === this.lastQueuedSequenceNumber, 0x0f1 /* "from arg" */);
let from = lastKnowOp + 1;
Expand Down

0 comments on commit d5b66f5

Please sign in to comment.