Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect roundtrip latencies for signals #10399

Closed
vladsud opened this issue May 22, 2022 · 1 comment
Closed

Collect roundtrip latencies for signals #10399

vladsud opened this issue May 22, 2022 · 1 comment
Assignees
@NicholasCouri
Labels
ado Issue is tracked in the internal Azure DevOps backlog
Milestone
June 2022

Comments

@vladsud
Copy link
Contributor

vladsud commented May 22, 2022

It would be great to collect roundtrip latencies for signals, similar to how we do so for ops.
It's much simpler for signals, as we have pretty much no pausing, no queues, etc.
So just measuring time between outbound and inbound queues would be sufficient.
This would be equivalent to durationInboundQueue property in OpRoundtripTime event.

Place where it would be of enormous help - #8908, where we would be able to compare times for ops and signals and tell with much more confidence if problems are in ordering service around op processing.
@vladsud vladsud added this to the June 2022 milestone May 22, 2022
@NicholasCouri
Copy link
Contributor

Tracked by https://dev.azure.com/fluidframework/internal/_workitems/edit/413

NicholasCouri added a commit to NicholasCouri/FluidFramework that referenced this issue Jun 3, 2022
@NicholasCouri
Draft for 413 - Collect roundtrip latencies for signals microsoft#10399
917a918
NicholasCouri added a commit that referenced this issue Jun 13, 2022
@NicholasCouri
Draft: Collect roundtrip latencies for signals (#10546)
33365dd 
Collect roundtrip latencies for signals #10399

Sending an error event in case we miss a signal.
@curtisman curtisman added the ado Issue is tracked in the internal Azure DevOps backlog label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicholasCouri NicholasCouri

Labels
ado Issue is tracked in the internal Azure DevOps backlog
Projects
None yet
Milestone
June 2022
Development

No branches or pull requests
3 participants
@curtisman @NicholasCouri @vladsud