Use pnpm in build-tools instead of npm #12236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbutler
added a commit
that referenced
this pull request
Nov 11, 2022
This has been broken out of PR #12236. This change enables fluid-build to use pnpm or yarn to install a release group's dependencies instead of npm. pnpm will only be used if there is a pnpm-workspace.yaml file in the root of the release group. yarn will only be used if there is a yarn.lock file in the root of the release group/package. Otherwise npm will be used. This change also includes some lint related changes that were uncovered by pnpm.
tylerbutler
commented
Nov 12, 2022
tylerbutler
commented
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This experimental PR switches the build-tools release group to use pnpm instead of npm to install and manage dependencies.
I made fluid-build changes in #12874 to keep it working when some release groups use pnpm and other release groups use npm. With these changes you can run
fluid-build --installand it will install using pnpm for those release groups that use it, and npm elsewhere.What about the client release group?
The client release group is currently at the root, so we can't use this approach as-is. However, we've been planning to reorganize the client anyway, so this PR assume we will move the client into its own folder under the root, at which point we can use pnpm on all release groups.
Summary of changes
--.