-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fluid-build): Enable fluid-build to use pnpm and yarn #12874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbutler
changed the title
feat(build-tools): Enable fluid-build to use pnpm
feat(fluid-build): Enable fluid-build to use pnpm
Nov 10, 2022
tylerbutler
changed the title
feat(fluid-build): Enable fluid-build to use pnpm
feat(fluid-build): Enable fluid-build to use pnpm and yarn
Nov 10, 2022
tylerbutler
commented
Nov 10, 2022
Josmithr
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!! Thank you!!!
tylerbutler
added a commit
that referenced
this pull request
Nov 22, 2022
This PR switches the build-tools release group to use pnpm instead of npm to install and manage dependencies. I made fluid-build changes in #12874 to keep it working when some release groups use pnpm and other release groups use npm. With these changes you can run `fluid-build --install` and it will install using pnpm for those release groups that use it, and npm elsewhere. ### Summary of changes - Added some missing devDeps that pnpm's strictness exposed. - Removed unneeded node types in tsconfig. - Update root prettier configs to use import sort plugin. - Updated scripts in release groups' root package.json to remove excess `--`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been broken out of PR #12236.
This change enables fluid-build to use pnpm or yarn to install a release group's dependencies instead of npm. pnpm will only be used if there is a pnpm-workspace.yaml file in the root of the release group. yarn will only be used if there is a yarn.lock file in the root of the release group/package. Otherwise npm will be used.
This PR also includes some lint related changes that were uncovered by pnpm.