Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fluid-build): Enable fluid-build to use pnpm and yarn #12874

Merged
merged 9 commits into from
Nov 11, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Nov 10, 2022

This has been broken out of PR #12236.

This change enables fluid-build to use pnpm or yarn to install a release group's dependencies instead of npm. pnpm will only be used if there is a pnpm-workspace.yaml file in the root of the release group. yarn will only be used if there is a yarn.lock file in the root of the release group/package. Otherwise npm will be used.

This PR also includes some lint related changes that were uncovered by pnpm.

@tylerbutler tylerbutler marked this pull request as ready for review November 10, 2022 02:20
@tylerbutler tylerbutler requested review from msfluid-bot and a team as code owners November 10, 2022 02:20
@github-actions github-actions bot added the base: main PRs targeted against main branch label Nov 10, 2022
@tylerbutler tylerbutler changed the title feat(build-tools): Enable fluid-build to use pnpm feat(fluid-build): Enable fluid-build to use pnpm Nov 10, 2022
@tylerbutler tylerbutler changed the title feat(fluid-build): Enable fluid-build to use pnpm feat(fluid-build): Enable fluid-build to use pnpm and yarn Nov 10, 2022
Copy link
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!! Thank you!!!

@tylerbutler tylerbutler merged commit ee53e3b into microsoft:main Nov 11, 2022
@tylerbutler tylerbutler deleted the fluid-build/pnpm branch November 11, 2022 02:34
tylerbutler added a commit that referenced this pull request Nov 22, 2022
This PR switches the build-tools release group to use pnpm
instead of npm to install and manage dependencies.

I made fluid-build changes in #12874 to keep it working when some
release groups use pnpm and other release groups use npm. With these
changes you can run `fluid-build --install` and it will install using
pnpm for those release groups that use it, and npm elsewhere.

### Summary of changes

- Added some missing devDeps that pnpm's strictness exposed.
- Removed unneeded node types in tsconfig.
- Update root prettier configs to use import sort plugin.
- Updated scripts in release groups' root package.json to remove excess
`--`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants