Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We have zero UTs for Summarizer class #7292

Closed
Tracked by #8030
vladsud opened this issue Aug 30, 2021 · 0 comments
Closed
Tracked by #8030

We have zero UTs for Summarizer class #7292

vladsud opened this issue Aug 30, 2021 · 0 comments
Assignees
@pleath
Labels
area: runtime: summarizer bug Something isn't working
Milestone
January 2022

Comments

@vladsud
Copy link
Contributor

vladsud commented Aug 30, 2021

An example of scenario to cover:
I almost made a regression around cancellation and last summaries - my initial approach to introducing cancellation token made Summarizer.stop() to also cancel cancellation token (coordinator), which made last summary running not possible (see PR #7230)

Overall, it would be nice to figure out a way to test it.
@vladsud vladsud added the bug Something isn't working label Aug 30, 2021
@vladsud vladsud added this to the October 2021 milestone Aug 30, 2021
vladsud added a commit to vladsud/FluidFramework that referenced this issue Aug 30, 2021
@vladsud
1. Cancelation token to return a reason for cancelation
011dac5 
2. Address earlier regression where all summaires (including last summary) were cancelled on main client being disconnected. Address by separating summarizer cancellation from cancellation token transitions, similar to how it was before.
Opened microsoft#7292 to track addition of UTs for Summarizer class.
@vladsud vladsud mentioned this issue Aug 30, 2021
Closed
@pleath pleath modified the milestones: October 2021, November 2021 Sep 28, 2021
@curtisman curtisman mentioned this issue Oct 28, 2021
Closed
11 tasks
@pleath pleath modified the milestones: November 2021, December 2021 Nov 8, 2021
@pleath pleath modified the milestones: December 2021, January 2022 Dec 13, 2021
@pleath pleath closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleath pleath

Labels
area: runtime: summarizer bug Something isn't working
Projects
None yet
Milestone
January 2022
Development

No branches or pull requests
2 participants
@pleath @vladsud