Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create connect() and disconnect() #9168

Closed
5 tasks done
Tracked by #8745
scottn12 opened this issue Feb 17, 2022 · 3 comments
Closed
5 tasks done
Tracked by #8745

Create connect() and disconnect() #9168

scottn12 opened this issue Feb 17, 2022 · 3 comments
Assignees
Labels
ado Issue is tracked in the internal Azure DevOps backlog epic An issue that is a parent to several other issues
Milestone

Comments

@scottn12
Copy link
Contributor

scottn12 commented Feb 17, 2022

As described in #8745, Container.connect() and Container.disconnect() will be introduced to provide developer-friendly APIs to control the connection state of a container. The functionality of connect() will be similar to the current Container.resume() (will be deprecated in #9167). disconnect() will have simlar functionality to the current Container.setAutoReconnect(false) API call (also deprecated in #9167).

Phases:

@ghost ghost added the triage label Feb 17, 2022
@scottn12 scottn12 changed the title Create connect() and disconnect() on Container Adjust setAutoReconnect() to remove immediate connection/disconnect logic Feb 25, 2022
@scottn12 scottn12 changed the title Adjust setAutoReconnect() to remove immediate connection/disconnect logic Create connect() and disconnect() on Container Feb 25, 2022
@markfields
Copy link
Member

@scottn12 - I believe manual connect/disconnect capability already exists, as resume() to connect and setAutoReconnect(false) to disconnect. Can you articulate what behavior changes you envision introducing with these new APIs, compared to these existing options? Or is this just about API naming?

@scottn12
Copy link
Contributor Author

scottn12 commented Mar 2, 2022

@markfields, I had initially planned for these APIs to have slightly different functionality. However, based on the latest design discussions in #8745, I believe these functions are going to be more about API naming as you alluded to. I will be sure to update the description of this issue once we get a bit more clarification!

@scottn12 scottn12 changed the title Create connect() and disconnect() on Container [WiP] Create connect() and disconnect() on Container Mar 3, 2022
@scottn12 scottn12 changed the title [WiP] Create connect() and disconnect() on Container Create connect() and disconnect() on Container Mar 8, 2022
@scottn12
Copy link
Contributor Author

scottn12 commented Mar 8, 2022

FYI, this issue has been updated to reflect the changes in #8745

@scottn12 scottn12 added this to the March 2022 milestone Mar 10, 2022
@scottn12 scottn12 self-assigned this Mar 10, 2022
@scottn12 scottn12 removed the triage label Mar 15, 2022
@scottn12 scottn12 modified the milestones: March 2022, April 2022 Mar 29, 2022
@skylerjokiel skylerjokiel moved this to In Progress in Fluid DevX Apr 2, 2022
@scottn12 scottn12 added the epic An issue that is a parent to several other issues label Apr 5, 2022
@scottn12 scottn12 changed the title Create connect() and disconnect() on Container Create connect() and disconnect() Apr 5, 2022
@skylerjokiel skylerjokiel modified the milestones: April 2022, May 2022 May 3, 2022
@skylerjokiel skylerjokiel added the ado Issue is tracked in the internal Azure DevOps backlog label May 18, 2022
@vladsud vladsud modified the milestones: May 2022, June 2022 Jun 3, 2022
Repository owner moved this from In Progress to Done in Fluid DevX Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ado Issue is tracked in the internal Azure DevOps backlog epic An issue that is a parent to several other issues
Projects
Status: Done
Development

No branches or pull requests

4 participants