Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connect() and disconnect() to Container and IContainer #9744

Closed
Tracked by #9168
scottn12 opened this issue Apr 5, 2022 · 0 comments · Fixed by #9439
Closed
Tracked by #9168

Add connect() and disconnect() to Container and IContainer #9744

scottn12 opened this issue Apr 5, 2022 · 0 comments · Fixed by #9439
Assignees
@scottn12
Milestone
April 2022

Comments

@scottn12
Copy link
Contributor

scottn12 commented Apr 5, 2022

No description provided.

@scottn12 scottn12 mentioned this issue Apr 5, 2022
Closed
5 tasks
@ghost ghost added the triage label Apr 5, 2022
@scottn12 scottn12 moved this to In Progress in Fluid DevX Apr 5, 2022
@scottn12 scottn12 changed the title Add connect() and disconnect() to Container Add connect() and disconnect() to Container and IContainer Apr 5, 2022
@scottn12 scottn12 self-assigned this Apr 5, 2022
@scottn12 scottn12 removed the triage label Apr 5, 2022
@scottn12 scottn12 mentioned this issue Apr 5, 2022
Merged
@scottn12 scottn12 linked a pull request Apr 5, 2022 that will close this issue
Add connect(), disconnect(), deprecate setAutoReconnect(), resume(), and connected #9439
Merged
@scottn12 scottn12 added this to the April 2022 milestone Apr 5, 2022
@scottn12 scottn12 moved this from In Progress to In Review in Fluid DevX Apr 5, 2022
Repository owner moved this from In Review to Done in Fluid DevX Apr 7, 2022
scottn12 added a commit that referenced this issue Apr 7, 2022
@scottn12
Add connect(), disconnect(), deprecate setAutoReconnect(), `res…
9031425 
…ume()`, and `connected` (#9439)

For context on the reasoning behind these changes see: #8745

This PR adds `connect()` and `disconnect()` to `Container` and `IContainer`. These functions will combine to replace the functionality of `Container.setAutoReconnect()` (which is deprecated here). Furthermore, `connect()` is essentially a rename of `Container.resume()`, hence `resume()` has been deprecated as well.

In addition, `IContainer.connected` has been deprecated in favor of `IContainer.connectionState`. To make `IFluidContainer` consistent with these changes, `connectionState` has been added to `IFluidContainer`, and `IFluidContainer.connected` has been deprecated as well.

Follow up items:
1. Add `connect()` and `disconnect()` to `IFluidContainer` and `IContainer`
2. Add tests for the new functionality
3. Update documentation referencing deprecated APIs
4. Explore behavior if `disconnect()` is called while the container is attempting to connect

Closes #9396, #9167, #9744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottn12 scottn12

Labels
None yet
Projects
Fluid DevX
Status: Done
Milestone
April 2022
1 participant
@scottn12