Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup @types after upgrading to socket.io v4 #9213

Closed
ChumpChief opened this issue Feb 22, 2022 · 0 comments · Fixed by #9479
Closed

Cleanup @types after upgrading to socket.io v4 #9213

ChumpChief opened this issue Feb 22, 2022 · 0 comments · Fixed by #9479
Labels
triage

Comments

@ChumpChief
Copy link
Contributor

Newer versions of socket.io bring their own TS types with them, so we should remove @types/socket.io-client dependencies: https://www.npmjs.com/package/@types/socket.io-client
@ghost ghost added the triage label Feb 22, 2022
@ChumpChief ChumpChief changed the title Cleanup after upgrading to socket.io v4 Cleanup @types after upgrading to socket.io v4 Feb 22, 2022
@ChumpChief ChumpChief mentioned this issue Feb 22, 2022
Merged
@ChumpChief ChumpChief mentioned this issue Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove outdated socket.io client types package ChumpChief/FluidFramework
1 participant
@ChumpChief