Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade socket.io-client to latest version #9212

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Feb 22, 2022

Fixes: #4608
Upgrading socket.io version to 4.4.1 so as to reduce the bundle size.

@jatgarg jatgarg added area: driver Driver related issues area: r11s-driver Issues related to r11s driver area: odsp-driver labels Feb 22, 2022
@jatgarg jatgarg added this to the February 2022 milestone Feb 22, 2022
@jatgarg jatgarg requested review from a team as code owners February 22, 2022 15:29
@jatgarg jatgarg self-assigned this Feb 22, 2022
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 22, 2022
@jatgarg jatgarg requested a review from a team as a code owner February 22, 2022 15:34
@github-actions github-actions bot added the area: examples Changes that focus on our examples label Feb 22, 2022
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: -36.11 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 385.4 KB 385.36 KB -40 Bytes
containerRuntime.js 185.95 KB 185.95 KB No change
loader.js 158.71 KB 158.67 KB -39 Bytes
map.js 201.04 KB 201.04 KB No change
matrix.js 295.57 KB 295.57 KB -6 Bytes
odspDriver.js 194 KB 158 KB -36 KB
odspPrefetchSnapshot.js 45.4 KB 45.4 KB No change
sharedString.js 315.75 KB 315.72 KB -26 Bytes
Total Size 1.77 MB 1.74 MB -36.11 KB

Baseline commit: c2cfb46

Generated by 🚫 dangerJS against 0973100

@christiango
Copy link
Member

36KB bundle size reduction for ODSP driver! We'll take it.

@jatgarg
Copy link
Contributor Author

jatgarg commented Feb 22, 2022

36KB bundle size reduction for ODSP driver! We'll take it.

Then smash that approve button :)

@jatgarg jatgarg merged commit 7df73c6 into microsoft:main Feb 22, 2022
@jatgarg jatgarg deleted the socket branch February 22, 2022 16:24
@ChumpChief
Copy link
Contributor

ChumpChief commented Feb 22, 2022

Opened #9213 for type cleanup.

We may eventually want to consider removing allowEIO3 configuration on the servers when the newer drivers become ubiquitous. We should at least be able to do this with tinylicious pretty aggressively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: examples Changes that focus on our examples area: odsp-driver area: r11s-driver Issues related to r11s driver dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Fluid to latest version of socket.io-client
4 participants