Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies version - server prerelease #10161

Closed
wants to merge 1 commit into from

Conversation

scottn12
Copy link
Contributor

@scottn12 scottn12 commented May 5, 2022

                              Server -> ^0.1036.3000-0

                                  Server -> ^0.1036.3000-0
@scottn12 scottn12 requested review from msfluid-bot and a team as code owners May 5, 2022 13:47
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels May 5, 2022
@scottn12
Copy link
Contributor Author

scottn12 commented May 5, 2022

Hi @tianzhu007, we are trying to bump dependencies on server packages to the new pre-release. We are getting some build errors that seem to be related to your changes in #10104. There are two uses of the modified IDocumentStorage.createDocument() function which need to be updated in the following files:

  1. packages/drivers/local-driver/src/localDocumentServiceFactory.ts
  2. server/tinylicious/src/routes/ordering/documents.ts

Should we simply set the new enableDiscovery param to false? If so, I can go ahead and make the changes, but I wanted to check with you first.

@scottn12 scottn12 marked this pull request as draft May 5, 2022 16:31
@tianzhu007 tianzhu007 closed this May 5, 2022
@tianzhu007 tianzhu007 reopened this May 5, 2022
@tianzhu007
Copy link
Contributor

Hi @tianzhu007, we are trying to bump dependencies on server packages to the new pre-release. We are getting some build errors that seem to be related to your changes in #10104. There are two uses of the modified IDocumentStorage.createDocument() function which need to be updated in the following files:

  1. packages/drivers/local-driver/src/localDocumentServiceFactory.ts
  2. server/tinylicious/src/routes/ordering/documents.ts

Should we simply set the new enableDiscovery param to false? If so, I can go ahead and make the changes, but I wanted to check with you first.

Yup. :) You can directly set enableDiscovery param to false, since this is only used in multiple clusters, not for the local test or tinylicious.

@scottn12 scottn12 closed this May 5, 2022
@scottn12 scottn12 deleted the dep_1651758313537 branch May 5, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: propertydds area: dds: sharedstring area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants