Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore some flaky font-related links #10453

Merged
merged 1 commit into from
May 27, 2022
Merged

Ignore some flaky font-related links #10453

merged 1 commit into from
May 27, 2022

Conversation

tylerbutler
Copy link
Member

Fixes #10267.

These font links are flaky when accessed from our CI systems, but as far as we know there's no customer impact in practice.

@github-actions github-actions bot added area: website base: main PRs targeted against main branch labels May 27, 2022
@github-actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast /home/runner/work/FluidFramework/FluidFramework/docs
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt "--external"

Crawling...

Stats:
   14033 links
     290 destination URLs
       1 URLs ignored
       0 warnings
       0 errors

@tylerbutler tylerbutler marked this pull request as ready for review May 27, 2022 17:29
@tylerbutler tylerbutler requested a review from a team as a code owner May 27, 2022 17:29
@tylerbutler tylerbutler requested review from ms-avocado and ssimic2 May 27, 2022 17:30
@tylerbutler tylerbutler merged commit 73929f2 into microsoft:main May 27, 2022
@tylerbutler tylerbutler deleted the docs/flaky-link-check branch May 27, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre4i andre4i andre4i approved these changes

@ms-avocado ms-avocado Awaiting requested review from ms-avocado

@ssimic2 ssimic2 Awaiting requested review from ssimic2

Assignees
No one assigned
Labels
area: website base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link checker often reports segoe-ui failures
2 participants
@tylerbutler @andre4i