disable message batching for Azure customers #11664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add e2e test to demo use of flush mode * override flush mode for azure clients * disable new test for local driver * PR feedback
github-actions
bot
added
area: framework
tylerbutler
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The problem reported by a customer via IcM. Attempting to sync a large data set consisting of batched multiple messages (less than 768kb each) will hit Socket.io buffer max size and the connection will close. The reason is the delta manager flushes batched messages periodically without enforcing the max op size. The max op size is only honored by the container runtime per each message submitted as imposed by the initial design.
The solution
Disable the message batching by setting
flushModetoIntermediatefor Azure customers. The workaround should be reconsidered when the original batching problem is resolved.