Add the Fix for Missing Ops Log, and telemetry for the Ops from the Last Service Summary #12295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianzhu007
changed the title
zhangxin511
reviewed
Oct 6, 2022
hedasilv
reviewed
Oct 7, 2022
server/routerlicious/packages/lambdas/src/scribe/summaryWriter.ts
Outdated
Show resolved
Hide resolved
pradeepvairamani
approved these changes
Oct 12, 2022
hedasilv
reviewed
Oct 13, 2022
server/routerlicious/packages/lambdas/src/scribe/summaryWriter.ts
Outdated
Show resolved
Hide resolved
hedasilv
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this pr to fix the wrong error logs that keep popping out for
Missing ops in the fullLogTail: ...
When we get the fullLogTail, it will still pop out the error message.
For example, if from = 5, and to = 9, the fullLogTailSequenceNumber = [5,6,7,8,9,10], it would return [6,7,8] as missing ops, which is not correct. This pr is to fix this case.
Meanwhile, we would print the SN for the missingOpsSN for ops fetched from the last summary.