Add Logs for SessionHelper #12574
Merged
Add Logs for SessionHelper #12574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: server
znewton
reviewed
Oct 19, 2022
server/routerlicious/packages/routerlicious-base/src/utils/sessionHelper.ts
Outdated
Show resolved
Hide resolved
znewton
reviewed
Oct 19, 2022
server/routerlicious/packages/routerlicious-base/src/utils/sessionHelper.ts
Outdated
Show resolved
Hide resolved
hedasilv
reviewed
Oct 19, 2022
server/routerlicious/packages/routerlicious-base/src/utils/sessionHelper.ts
Outdated
Show resolved
Hide resolved
hedasilv
reviewed
Oct 19, 2022
server/routerlicious/packages/routerlicious-base/src/utils/sessionHelper.ts
Show resolved
Hide resolved
znewton
approved these changes
Oct 19, 2022
hedasilv
approved these changes
Oct 19, 2022
server/routerlicious/packages/routerlicious-base/src/utils/sessionHelper.ts
Outdated
Show resolved
Hide resolved
hedasilv
approved these changes
Oct 24, 2022
hedasilv
reviewed
Oct 24, 2022
server/routerlicious/packages/routerlicious-base/src/utils/sessionHelper.ts
Show resolved
Hide resolved
hedasilv
approved these changes
Oct 24, 2022
pradeepvairamani
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have one session existing in the two clusters at the same time, we don't have enough telemetry to debug this case. When a client would like to open an existing session, it might doesn't follow the session stickiness time, and directly join from the wrong cluster. For example, one session just terminated in cluster A. After a few minutes, it violate the session stickiness time (3 hours) and was open in cluster B.
We would like to add more telemetry to debug this scenario.