Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Count Variable in sessionHelper.ts #13082

Merged
merged 21 commits into from
Nov 23, 2022
Merged

Remove Count Variable in sessionHelper.ts #13082

Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
54da26d
Make the update atomic
tianzhu007 Oct 26, 2022
360eac7
Address the comment
tianzhu007 Oct 26, 2022
fa40454
Make the default value
tianzhu007 Oct 26, 2022
a0528ec
Merge branch 'microsoft:main' into tianzhu/fix-routing-racing
tianzhu007 Nov 14, 2022
56f3333
Merge branch 'microsoft:main' into tianzhu/fix-routing-racing
tianzhu007 Nov 16, 2022
b6861c7
Update the method
tianzhu007 Nov 16, 2022
af75e65
Add the one line
tianzhu007 Nov 16, 2022
98d2e2e
Edit the file for update method
tianzhu007 Nov 16, 2022
d4192e1
Change the method
tianzhu007 Nov 16, 2022
4ea308f
Update the telemetry
tianzhu007 Nov 16, 2022
a945117
Edit the comments
tianzhu007 Nov 16, 2022
4b5cfec
Merge branch 'microsoft:main' into tianzhu/fix-routing-racing
tianzhu007 Nov 17, 2022
a898014
Add the tenant id
tianzhu007 Nov 17, 2022
dd80b43
Merge branch 'microsoft:main' into tianzhu/fix-routing-racing
tianzhu007 Nov 21, 2022
5edc762
Remove the recursion
tianzhu007 Nov 21, 2022
960a690
Add the runWithRetry
tianzhu007 Nov 21, 2022
c936c6f
Edit the error message
tianzhu007 Nov 22, 2022
c9ad29d
Add the json.stringify
tianzhu007 Nov 22, 2022
6113378
Remove unnecessary variable
tianzhu007 Nov 23, 2022
35916ef
Merge branch 'main' into tianzhu/fix-routing-racing
tianzhu007 Nov 23, 2022
d126880
Remove the count
tianzhu007 Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions server/routerlicious/packages/routerlicious-base/src/utils/sessionHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ async function updateExistingSession(
documentsCollection: ICollection<IDocument>,
sessionStickinessDurationMs: number,
lumberjackProperties: Record<string, any>,
count: number,
): Promise<ISession> {
let updatedDeli: string | undefined;
let updatedScribe: string | undefined;
Expand Down Expand Up @@ -223,7 +222,6 @@ export async function getSession(
documentId: string,
documentsCollection: ICollection<IDocument>,
sessionStickinessDurationMs: number = defaultSessionStickinessDurationMs,
count: number = 0,
): Promise<ISession> {
const lumberjackProperties = getLumberBaseProperties(documentId, tenantId);

Expand Down Expand Up @@ -269,7 +267,6 @@ export async function getSession(
documentsCollection,
sessionStickinessDurationMs,
lumberjackProperties,
count,
);
return convertSessionToFreshSession(updatedSession, lumberjackProperties);
}