Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port v2int 3.0] Reset gc for old snapshots 3.0 #14918

Merged
merged 1 commit into from
Apr 1, 2023
Merged

[Port v2int 3.0] Reset gc for old snapshots 3.0 #14918

merged 1 commit into from
Apr 1, 2023

Conversation

tyler-cai-microsoft
Copy link
Contributor

Cherry pick #14906 fix to 3.0

@tyler-cai-microsoft @agarwal-navin
Ignore old snapshots and assume gc should be regenerated (microsoft#1…
1384a31 
…4906)

From Hammon Pang
> It looks like there are some older files (last updated in 2022) that
were used recently but can’t summarize due to the following
FluidElementNotFound error during PostSnapshot:
>
> Cannot locate node with path '[omitted]/gc' under '[omitted]'.

The solution here is that for older snapshots gc will now ignore, and
regenerate the whole gc blob and submit it. The thought here is that we
cannot use older snapshots for doing incremental GC summary. So, to keep
things simple we ignore them and regenerate the GC data. This is
expensive but it should happen very rarely.

---------

Co-authored-by: Navin Agarwal <[email protected]>
@tyler-cai-microsoft tyler-cai-microsoft requested review from msfluid-bot and a team as code owners March 31, 2023 23:57
@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file public api change Changes to a public API labels Mar 31, 2023
@tyler-cai-microsoft tyler-cai-microsoft changed the base branch from main to release/v2int/3.0 March 31, 2023 23:57
@github-actions github-actions bot added the base: main PRs targeted against main branch label Mar 31, 2023
@msfluid-bot
Copy link
Collaborator

Could not find a usable baseline build with search starting at CI 8c4ab26

Generated by 🚫 dangerJS against 1384a31

@tyler-cai-microsoft tyler-cai-microsoft merged commit 346e62c into microsoft:release/v2int/3.0 Apr 1, 2023
tyler-cai-microsoft added a commit to tyler-cai-microsoft/FluidFramework that referenced this pull request Apr 1, 2023
@tyler-cai-microsoft @agarwal-navin
[Port v2int 3.0] Reset gc for old snapshots 3.0 (microsoft#14918)
1dfc50a 
Cherry pick microsoft#14906 fix
to 3.0

Co-authored-by: Navin Agarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenn-le jenn-le jenn-le approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees
No one assigned
Labels
area: build Build related issues area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyler-cai-microsoft @msfluid-bot @jenn-le