Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Up Mongodb SDK to 4.13.0 #15607

Merged
merged 35 commits into from
May 19, 2023
Merged

Bump Up Mongodb SDK to 4.13.0 #15607

merged 35 commits into from
May 19, 2023

Conversation

tianzhu007
Copy link
Contributor

Bump Up Mongodb SDK to 4.13.0

Change the docker image to mongo:3.6 to compile with new SDK.
I refactored server/routerlicious/packages/services/src/mongodb.ts to fit the latest Mongodb SDK.
In MongoClientOptions:
The autoReconnect, bufferMaxEntries, reconnectInterval, and reconnectTries have been deprecated:
https://mongodb.github.io/node-mongodb-native/3.4/reference/unified-topology/
The useNewUrlParser has been deprecated:
https://www.mongodb.com/community/forums/t/argument-of-type-usenewurlparser-boolean-useunifiedtopology-boolean-is-not-assignable-to-parameter-of-type/169033

tianzhu007 and others added 30 commits February 7, 2023 16:12
@tianzhu007
Stash the change
fb52eba
@tianzhu007
Merge branch 'microsoft:main' into bump-up-mongodb-sdk
0a04d3c
@tianzhu007
Update the mongodb.ts
4c8c03a
@tianzhu007
Commit the fix for bufferMaxEntries
85dddd0
@tianzhu007
Fix the syntax
c8c228f
@tianzhu007
Add the returnDocument
f6acbb7
@tianzhu007
Merge branch 'microsoft:main' into bump-up-mongodb-sdk
7a8f038
@tianzhu007
Add the IThrottler to avoid unsafe return
cec65e3
@tianzhu007
Add ;
03fb966
@tianzhu007
Update pnpm-lock.yaml
3800ccd
@tianzhu007
Adjust the header
68ac292
@tianzhu007
Merge branch 'microsoft:main' into bump-up-mongodb-sdk
c835f3d
@tianzhu007
Revert the mongodb version in docker
d411a41
@tianzhu007
Remove useUnifiedTopolify
8d2c51a
@tianzhu007
Merge branch 'bump-up-mongodb-sdk' of https://github.com/tianzhu007/F…
6856fe9 
…luidFramework into bump-up-mongodb-sdk

# Conflicts:
#	server/routerlicious/packages/services/package.json
@tianzhu007
Change the findAndUpdate parameter
a21eb41
@tianzhu007
Remove two unnecessary variblaes
6089e27
@tianzhu007
Remove @types/mongodb
e8d1139
@tianzhu007
Remove the cast
64d434a
@tianzhu007
Add ;
8ddd9e1
@tianzhu007
Change the docker image
610a164
@tianzhu007
Merge branch 'main' into bump-up-mongodb-sdk
4f74042 
# Conflicts:
#	server/routerlicious/packages/routerlicious-base/src/alfred/runnerFactory.ts
#	server/routerlicious/packages/routerlicious/config/config.json
#	server/routerlicious/packages/services-core/src/database.ts
#	server/routerlicious/packages/services/package.json
#	server/routerlicious/packages/services/src/mongodb.ts
#	server/routerlicious/pnpm-lock.yaml
@tianzhu007
Remove extra line
6cfa9ca
@tianzhu007
Add generic type
2d597d8
@tianzhu007
Merge branch 'microsoft:main' into bump-up-mongodb-sdk
36473ad
@tianzhu007
Add the format
bd3d9f7
@tianzhu007
Merge branch 'main' into bump-up-mongodb-sdk
7154ef7 
Resolve Conflicts:
#	server/routerlicious/packages/services/src/mongodb.ts
#	server/routerlicious/pnpm-lock.yaml
@tianzhu007
Merge branch 'main' into bump-up-mongodb-sdk
09da9e9 
# Conflicts:
#	server/routerlicious/kubernetes/routerlicious/values.yaml
#	server/routerlicious/pnpm-lock.yaml
@tianzhu007
Add two lines
bb95719
@tianzhu007
Revert the npmrc file
ed9a93d
tianzhu007 added 3 commits May 10, 2023 14:44
@tianzhu007
Remove extra files
a08f814
@tianzhu007
Add back the deleted files
82f2dad
@tianzhu007
Merge branch 'bump-up-mongodb-sdk' into bump-up-mongodb-sdk-2
2b7cff1 
# Conflicts:
#	pnpm-lock.yaml
#	server/routerlicious/kubernetes/routerlicious/values.yaml
@github-actions github-actions bot added the base: main PRs targeted against main branch label May 16, 2023
@tianzhu007 tianzhu007 requested review from msfluid-bot and a team as code owners May 16, 2023 18:20
@github-actions github-actions bot added area: server Server related issues (routerlicious) dependencies Pull requests that update a dependency file labels May 16, 2023
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented May 16, 2023 •
edited
Loading

⯆ @fluid-example/bundle-size-tests: -2.23 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 446.96 KB 446.99 KB ⯅ +34 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 239.2 KB 239.21 KB ⯅ +5 Bytes
loader.js 155.36 KB 155.39 KB ⯅ +35 Bytes
map.js 46.66 KB 46.66 KB ⯅ +2 Bytes
matrix.js 140.5 KB 140.5 KB ⯅ +2 Bytes
odspDriver.js 92.43 KB 92.44 KB ⯅ +4 Bytes
odspPrefetchSnapshot.js 43.64 KB 43.64 KB ⯅ +4 Bytes
sharedString.js 161.46 KB 161.47 KB ⯅ +2 Bytes
sharedTree2.js 274.05 KB 273.06 KB ⯆ -1009 Bytes
Total Size 1.72 MB 1.72 MB ⯆ -2.23 KB

Baseline commit: 4acda11

Generated by 🚫 dangerJS against facd34b

@tianzhu007
Merge branch 'main' into bump-up-mongodb-sdk-2
facd34b 
# Conflicts:
#	pnpm-lock.yaml
@tianzhu007 tianzhu007 merged commit 7e2393e into microsoft:main May 19, 2023
@CraigMacomber CraigMacomber mentioned this pull request Jun 1, 2023
Merged
tylerbutler pushed a commit that referenced this pull request Jun 2, 2023
@CraigMacomber
Revert client package lock changes from c7e2393ebb78e72d5f9f0d3ea1cf8…
6d2d570 
…41c4827062ed (#15812)

## Description

Looks like #15607 made a
change with a bad merge that overwrote the client package lock update
for client when updating server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangxin511 zhangxin511 zhangxin511 approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees
No one assigned
Labels
area: server Server related issues (routerlicious) base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianzhu007 @msfluid-bot @zhangxin511