Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2int 4.3 port] Don't schedule session refresh timers multiple times (#15596) #15956

Merged
merged 2 commits into from
Jun 13, 2023
Merged

[v2int 4.3 port] Don't schedule session refresh timers multiple times (#15596) #15956

merged 2 commits into from
Jun 13, 2023

Conversation

kian-thompson
Copy link
Contributor

Description

ADO:3850. We can avoid scheduling these twice in order to avoid a memory leak. However, there seems to be an uncaught code path which does not clean up properly. Adding a log to give us a better view on things.

See #15596

@andre4i @kian-thompson
Don't schedule session refresh timers multiple times (microsoft#15596)
4123c75 
## Description

ADO:3850. We can avoid scheduling these twice in order to avoid a memory
leak. However, there seems to be an uncaught code path which does not
clean up properly. Adding a log to give us a better view on things.
@kian-thompson kian-thompson requested a review from noencke June 12, 2023 21:15
@kian-thompson kian-thompson requested review from a team as code owners June 12, 2023 21:15
@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver base: release PRs targeted against a release branch labels Jun 12, 2023
@msfluid-bot
Copy link
Collaborator

⯅ @fluid-example/bundle-size-tests: +327 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 446.96 KB 446.96 KB ⯅ +6 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 239.2 KB 239.2 KB ⯅ +2 Bytes
loader.js 155.36 KB 155.36 KB ⯅ +4 Bytes
map.js 46.66 KB 46.66 KB ⯅ +2 Bytes
matrix.js 140.5 KB 140.5 KB ⯅ +2 Bytes
odspDriver.js 92.43 KB 92.44 KB ⯅ +6 Bytes
odspPrefetchSnapshot.js 43.64 KB 43.64 KB ⯅ +4 Bytes
sharedString.js 161.46 KB 161.47 KB ⯅ +2 Bytes
sharedTree2.js 272.91 KB 272.91 KB ■ No change
Total Size 1.72 MB 1.72 MB ⯅ +327 Bytes

Baseline commit: 423c903

Generated by 🚫 dangerJS against b7d3dd6

@kian-thompson kian-thompson merged commit 9e1d1af into microsoft:release/v2int/4.3 Jun 13, 2023
@kian-thompson kian-thompson deleted the session-refresh-4.3 branch June 13, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noencke noencke noencke approved these changes

Assignees
No one assigned
Labels
area: driver Driver related issues area: odsp-driver base: release PRs targeted against a release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kian-thompson @msfluid-bot @noencke @andre4i