Populating sub directories correctly in Shared Directory (#15982) #15991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Populating sub directories correctly in Shared Directory. When we serialize a new directory on attach and record the csn which is -1 for a newly create one, then on load, we load with -1 csn for that. Now there is no create op for this subdir. So when a new subdir is added in that dir and create op comes for that, it does not pass this check below and we don't process that op. https://github.com/microsoft/FluidFramework/blob/a51cd2afc8fb11e11c083f9f62fa9e69727e6845/packages/dds/map/src/directory.ts#L2150 --------- Co-authored-by: Jatin Garg <[email protected]>
github-actions
bot
added
area: dds
kian-thompson
approved these changes
Jun 14, 2023
⯅ @fluid-example/bundle-size-tests: +40 Bytes
Baseline commit: 1c5241f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Populating sub directories correctly in Shared Directory. When we serialize a new directory on attach and record the csn which is -1 for a newly create one, then on load, we load with -1 csn for that. Now there is no create op for this subdir. So when a new subdir is added in that dir and create op comes for that, it does not pass this check below and we don't process that op.
FluidFramework/packages/dds/map/src/directory.ts
Line 2150 in a51cd2a