Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to release @fluid-internal/client-utils package #17208

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Sep 7, 2023

Description

Add ability to release @fluid-internal/client-utils package

@jatgarg jatgarg self-assigned this Sep 7, 2023
@jatgarg jatgarg requested a review from a team as a code owner September 7, 2023 18:20
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to unblock quickly but let's capture an ADO item to change this to have an explicit list of the ones we don't want to publish, so we don't have to manually add future @fluid-internal packages here when we create them.

Not sure if this is necessary or would work by default, but we probably want to update the lines right above the change to also create an entry in .npmrc for the @fluid-internal scope. In line 42 we do it for the case of publishing packages internally; when publishing externally we'll want to use feedName instead of devFeedName so they go to npm, just like all the other scopes in lines 50-52.

Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another set of eyes would be ideal, but I think this is correct

@jatgarg
Copy link
Contributor Author

jatgarg commented Sep 7, 2023

I think it's fine to unblock quickly but let's capture an ADO item to change this to have an explicit list of the ones we don't want to publish, so we don't have to manually add future @fluid-internal packages here when we create them.

Not sure if this is necessary or would work by default, but we probably want to update the lines right above the change to also create an entry in .npmrc for the @fluid-internal scope. In line 42 we do it for the case of publishing packages internally; when publishing externally we'll want to use feedName instead of devFeedName so they go to npm, just like all the other scopes in lines 50-52.

I think this is a temporary change as once we divide internal and private packages, then we need to change this and publish all internal packages and block private packages

@jatgarg jatgarg merged commit 82641e6 into microsoft:release/v2int/6.3 Sep 7, 2023
jatgarg added a commit to jatgarg/FluidFramework-1 that referenced this pull request Sep 7, 2023
…t#17208)

## Description

Add ability to release @fluid-internal/client-utils package

---------

Co-authored-by: Jatin Garg <[email protected]>
@jatgarg jatgarg deleted the fixpipeline branch September 7, 2023 21:10
jatgarg added a commit that referenced this pull request Sep 7, 2023
…ient-utils package (#17208) (#17214)

## Description

Add ability to release @fluid-internal/client-utils package

Co-authored-by: Jatin Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants