-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to release @fluid-internal/client-utils package #17208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to unblock quickly but let's capture an ADO item to change this to have an explicit list of the ones we don't want to publish, so we don't have to manually add future @fluid-internal packages here when we create them.
Not sure if this is necessary or would work by default, but we probably want to update the lines right above the change to also create an entry in .npmrc
for the @fluid-internal
scope. In line 42 we do it for the case of publishing packages internally; when publishing externally we'll want to use feedName
instead of devFeedName
so they go to npm, just like all the other scopes in lines 50-52.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another set of eyes would be ideal, but I think this is correct
I think this is a temporary change as once we divide internal and private packages, then we need to change this and publish all internal packages and block private packages |
…t#17208) ## Description Add ability to release @fluid-internal/client-utils package --------- Co-authored-by: Jatin Garg <[email protected]>
…ient-utils package (#17208) (#17214) ## Description Add ability to release @fluid-internal/client-utils package Co-authored-by: Jatin Garg <[email protected]>
Description
Add ability to release @fluid-internal/client-utils package