Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree2): Fix move within sequence #17817

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Oct 17, 2023

Description

Fixes assertion code path intended to protect against moving nodes between different kinds of sequences, when moving nodes within a sequence (the source and target sequences are the same, and thus the same kind).

Also moves the assert to earlier in the method to fail fast.

Reviewer Guidance

The review process is outlined on this wiki page.

@alexvy86 alexvy86 requested a review from a team as a code owner October 17, 2023 15:38
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Oct 17, 2023
@alexvy86 alexvy86 enabled auto-merge (squash) October 17, 2023 20:46
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +16 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 444.99 KB 444.99 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 238.14 KB 238.14 KB No change
loader.js 178.25 KB 178.25 KB No change
map.js 48.06 KB 48.06 KB No change
matrix.js 141.84 KB 141.84 KB No change
odspDriver.js 90.24 KB 90.24 KB No change
odspPrefetchSnapshot.js 41.75 KB 41.75 KB No change
sharedString.js 162.68 KB 162.68 KB No change
sharedTree2.js 265.97 KB 265.98 KB +16 Bytes
Total Size 1.72 MB 1.72 MB +16 Bytes

Baseline commit: f7690e3

Generated by 🚫 dangerJS against 1b4d3e0

@alexvy86 alexvy86 merged commit 9a03a6a into microsoft:main Oct 17, 2023
@alexvy86 alexvy86 deleted the fix-editabletree2-move branch October 17, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants