-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'after' support #17925
Add 'after' support #17925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to review the comments a bit more but let's merge and I will follow up with another PR with comment changes and any questions. Then you can just review. Thanks again for doing this!
@@ -65,25 +65,47 @@ export abstract class Task { | |||
// This function should only be called by task with task names | |||
assert.notStrictEqual(this.taskName, undefined); | |||
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |||
this.dependentTasks = this.node.getDependentTasks(this, this.taskName!, pendingInitDep); | |||
this.dependentTasks = this.node.getDependsOnTasks(this, this.taskName!, pendingInitDep); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why the earlier assertion doesn't narrow the type here so the ! isn't needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node's typing for the assert function probably doesn't have assertions.
Co-authored-by: Tyler Butler <[email protected]>
Similar to 'before', 'after' will schedule the task to be executed after all the specified task is executed.
Also,
dependsOn
.