Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy(tree): comments and other nits #17981

Merged
merged 1 commit into from
Oct 25, 2023
Merged

tidy(tree): comments and other nits #17981

merged 1 commit into from
Oct 25, 2023

Conversation

DLehenbauer
Copy link
Contributor

Addressing some deferred PR feedback (comments, spelling and internal renaming)

@DLehenbauer DLehenbauer requested a review from a team as a code owner October 25, 2023 18:36
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Oct 25, 2023
@DLehenbauer DLehenbauer enabled auto-merge (squash) October 25, 2023 18:47
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +2 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 446.18 KB 446.18 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 239.26 KB 239.26 KB No change
loader.js 178.73 KB 178.73 KB No change
map.js 48.06 KB 48.06 KB No change
matrix.js 141.84 KB 141.84 KB No change
odspDriver.js 90.27 KB 90.27 KB No change
odspPrefetchSnapshot.js 41.9 KB 41.9 KB No change
sharedString.js 162.75 KB 162.75 KB No change
sharedTree2.js 263.21 KB 263.21 KB +2 Bytes
Total Size 1.72 MB 1.72 MB +2 Bytes

Baseline commit: 105c818

Generated by 🚫 dangerJS against 520298f

@DLehenbauer DLehenbauer merged commit 119dc5a into main Oct 25, 2023
27 checks passed
@DLehenbauer DLehenbauer deleted the nits branch October 25, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants