[v2int/7.0] Port #17841 (GC: Do not throw when loading a DDS that is Inactive or Tombstoned) #17984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icrosoft#17841) Some early adopters of GC are utilizing the `allowTombstone` header (and something similar for InactiveObject) to take control of how they interact with Tombstoned objects. They found that while this technique allows them to get at a DataStore-level object, there are some flows where that triggers the load of a DDS via handle.get, which fails. And since GC Mark happens at DataStore granularity, we are no longer going to enforce Tombstone (or Inactive) state when directly loading a DDS. (Implication is that an app trying to leverage Tombstone state will miss out on this detection if ever a DDS is loaded directly before its DataStore was loaded).
agarwal-navin
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #17841 to
release/v2int/7.0