[v2int/7.2] Port #18013 (Improve tombstone logs to include additional unreferenced state) #18044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osoft#18013) The tombstone logs don't include some crucial information such as the timestamp when the object was unreferenced, how long it has been unreferenced for, what was the sweep timeout and in case of loaded events, it doesn't include the package information. This makes it very hard to debug issues. This PR moves the tombstone telemetry logging and error handling for loaded, changed (op process) and revived into garbage collector along with the inactive telemetry logic. Since garbage collector has all the state of the tombstoned object, this makes it easier to log that information without having to duplicate or expose it to other objects. [AB#5760](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/5760) - "Initialize GC immediately, then update Tracking timestamp upon Connect" [AB#5769](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/5769)
⯆ @fluid-example/bundle-size-tests: -364 Bytes
Baseline commit: c1adba1 |
rajatch-ff
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #18013 to
release/v2int/7.2