Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port v2int 7.1] Fixes and improvements around grouped batching #18183

Merged

Conversation

kian-thompson
Copy link
Contributor

@kian-thompson kian-thompson commented Nov 7, 2023

See #18004 and #18171

ADO:6050

Basically the same bug as
microsoft#17913, but for
SharedMap
@kian-thompson kian-thompson requested a review from andre4i November 7, 2023 17:25
@kian-thompson kian-thompson changed the title [Port v2int 7.1] Fixes and improvements around grouped batching #18182 [Port v2int 7.1] Fixes and improvements around grouped batching Nov 7, 2023
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 7, 2023

Could not find a usable baseline build with search starting at CI 23fae8b

Generated by 🚫 dangerJS against feb06f7

## Description

ADO:6102

Using feature gates, allow for enabling grouped batching only for:

- batches over a certain limit
- batches which are not reentrant

All other batches will not be grouped. The goal here is to maybe fix
some large payload scenarios and at the same time minimize the risk
added by the grouped batching feature.

### As rebasing is required for grouped batching, this change will make
it so that rebasing does not happen unless the batch will actually get
grouped.
@kian-thompson kian-thompson marked this pull request as ready for review November 7, 2023 18:02
@kian-thompson kian-thompson requested review from a team as code owners November 7, 2023 18:02
@kian-thompson kian-thompson merged commit 134ef13 into microsoft:release/v2int/7.1 Nov 7, 2023
@kian-thompson kian-thompson deleted the grouped-batching-7.1 branch November 7, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants