build: Update shared api-extractor lint config to enable enforcement #18791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
|
Waiting for the next release to be cut before merging. |
Josmithr
commented
Dec 12, 2023
| @@ -45,7 +45,7 @@ | |||
| // This is the primary error we are looking for with the linter pass. | |||
| // Ensure that release tags of API members are compatible **across package boundaries**. | |||
| "ae-incompatible-release-tags": { | |||
| "logLevel": "none", // TODO: change to "error" once we are ready to start enforcing repo-wide | |||
| "logLevel": "error", | |||
There was a problem hiding this comment.
For reviewers: this is the primary change. Set as an error now, so all configs extending this can remove the override.
alexvy86
approved these changes
Dec 12, 2023
|
nit on the pr title: maybe api-extractor instead of lint? Not sure that's better or more accurate. |
Josmithr
changed the title
Josmithr
commented
Dec 12, 2023
| "extends": "../../../common/build/build-common/api-extractor-lint.json" | ||
| "extends": "../../../common/build/build-common/api-extractor-lint.json", | ||
| "messages": { | ||
| "extractorMessageReporting": { |
There was a problem hiding this comment.
This was necessary - tree2 was the only package explicitly not linting cross-package compat.
⯅ @fluid-example/bundle-size-tests: +14 Bytes
Baseline commit: 600c2be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes package-local overrides, which are no longer necessary