fix(client): use @ungap/structuredClone for structuredClone implementation #19283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation (microsoft#19279) Updating structuredClone usage to explicit import from @ungap/structuredClone to align with Loop's browser support matrix and to prevent issues with structuredClone not being available in Jest test environment. https://www.npmjs.com/package/@ungap/structured-clone?activeTab=readme Jest test for app-insights-logger seems to be resulting with a false pass due to some underlying ESM configuration issues: https://dev.azure.com/fluidframework/internal/_build/results?buildId=230705&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=ca111d9b-56f7-5b3d-b8f6-661164061440&l=1359 skipping test for app-insights-logger example for now. Follow up item to resolve test issues: https://dev.azure.com/fluidframework/internal/_workitems/edit/7001
alexvy86
approved these changes
Jan 18, 2024
⯅ @fluid-example/bundle-size-tests: +2.35 KB
Baseline commit: 96c7f92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update structuredClone implementation to use explicit import
Original PR from main: #19279