Add some telemetry for the (former) 0x162 assert. (#19415) - 7.4 #19423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description ADO:7045 The assert doesn't tell us much about the context of the error. Converting this into a `DataProcessingError`. I am aware that this is likely a data corruption incident, but technically it's a data processing error as the error happens when we process an op. The fact that the error doesn't recover leads to data corruption, but theoretically if a client would load a good summary, it may be able to recover. ### After it is merged, I propose we backport this to 7.4.* and 8.0.*.
andre4i
changed the title
NicholasCouri
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADO:7045
The assert doesn't tell us much about the context of the error. Converting this into a
DataProcessingError.I am aware that this is likely a data corruption incident, but technically it's a data processing error as the error happens when we process an op. The fact that the error doesn't recover leads to data corruption, but theoretically if a client would load a good summary, it may be able to recover.
Porting #19415 from
main