-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simulated stashing and applyStashedOps in the ddsFuzzHarness #19634
Merged
anthony-murphy
merged 26 commits into
microsoft:main
from
anthony-murphy:prototype-stashedops-dds-fuzz
Feb 16, 2024
Merged
Add simulated stashing and applyStashedOps in the ddsFuzzHarness #19634
anthony-murphy
merged 26 commits into
microsoft:main
from
anthony-murphy:prototype-stashedops-dds-fuzz
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to prototype-stashedops-dds-fuzz
…to prototype-stashedops-dds-fuzz
…to prototype-stashedops-dds-fuzz
…to prototype-stashedops-dds-fuzz
…to prototype-stashedops-dds-fuzz
anthony-murphy
commented
Feb 15, 2024
jzaffiro
reviewed
Feb 15, 2024
⯅ @fluid-example/bundle-size-tests: +187 Bytes
Baseline commit: 3aad53d |
…thony-murphy/FluidFramework-1 into prototype-stashedops-dds-fuzz
connorskees
reviewed
Feb 15, 2024
anthony-murphy
commented
Feb 15, 2024
packages/runtime/test-runtime-utils/src/mocksForReconnection.ts
Outdated
Show resolved
Hide resolved
…to prototype-stashedops-dds-fuzz
anthony-murphy
commented
Feb 16, 2024
clarenceli-msft
approved these changes
Feb 16, 2024
anthony-murphy
added a commit
that referenced
this pull request
Mar 1, 2024
…19893) ## Background This change is the final change for allowing consumers of fluid to call serialize on a container while a container is in an attaching state, which will include a failed attach where the failure didn't cause the container to close. This will aid in the case of offline, network, or server outage by allowing the application to capture the un-attached state of the container, preserve it locally, and later create a new file from it. [AB#5502](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/5502) ## Overview This change enables calling container.serialize while a container is in the attaching state. It is the culmination of many smaller changes that have gone in to enable this change. - #18829 - #19400 - #19246 - #19517 - #19518 - #19590 - #19634 - #19802 --------- Co-authored-by: Tony Murphy <[email protected]> Co-authored-by: Daniel Madrid <[email protected]> Co-authored-by: jzaffiro <[email protected]> Co-authored-by: Matt Rakow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds
Issues related to distributed data structures
area: runtime
Runtime related issues
base: main
PRs targeted against main branch
dependencies
Pull requests that update a dependency file
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the existing mocks by enabling applyStashedOps, and adds support to the ddsFuzzHarness to simulate capturing pending state, closing, and re-opening a client.
In this PR i've also enabled the new workload on sharedMap.