Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulated stashing and applyStashedOps in the ddsFuzzHarness #19634

Merged

Conversation

anthony-murphy
Copy link
Contributor

This change improves the existing mocks by enabling applyStashedOps, and adds support to the ddsFuzzHarness to simulate capturing pending state, closing, and re-opening a client.

In this PR i've also enabled the new workload on sharedMap.

@anthony-murphy anthony-murphy requested review from Abe27342, connorskees, jzaffiro and dannimad and removed request for connorskees February 14, 2024 22:58
@github-actions github-actions bot added base: main PRs targeted against main branch area: dds Issues related to distributed data structures area: runtime Runtime related issues dependencies Pull requests that update a dependency file public api change Changes to a public API labels Feb 14, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Feb 15, 2024

@fluid-example/bundle-size-tests: +187 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 511.82 KB 511.86 KB +44 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 244.63 KB 244.65 KB +22 Bytes
loader.js 170.65 KB 170.67 KB +22 Bytes
map.js 46.41 KB 46.42 KB +11 Bytes
matrix.js 149.11 KB 149.12 KB +11 Bytes
odspDriver.js 97.67 KB 97.7 KB +33 Bytes
odspPrefetchSnapshot.js 42.63 KB 42.65 KB +22 Bytes
sharedString.js 168.49 KB 168.5 KB +11 Bytes
sharedTree.js 333.77 KB 333.77 KB No change
Total Size 1.87 MB 1.87 MB +187 Bytes

Baseline commit: 3aad53d

Generated by 🚫 dangerJS against 0b16dee

@anthony-murphy anthony-murphy changed the title Add simulated stashing and applyStashedOps tests in the ddsFuzzHarness Add simulated stashing and applyStashedOps in the ddsFuzzHarness Feb 16, 2024
@anthony-murphy anthony-murphy merged commit 24e2c66 into microsoft:main Feb 16, 2024
30 checks passed
@anthony-murphy anthony-murphy deleted the prototype-stashedops-dds-fuzz branch February 16, 2024 17:08
anthony-murphy added a commit that referenced this pull request Mar 1, 2024
…19893)

## Background
This change is the final change for allowing consumers of fluid to call
serialize on a container while a container is in an attaching state,
which will include a failed attach where the failure didn't cause the
container to close. This will aid in the case of offline, network, or
server outage by allowing the application to capture the un-attached
state of the container, preserve it locally, and later create a new file
from it.


[AB#5502](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/5502)

## Overview
This change enables calling container.serialize while a container is in
the attaching state. It is the culmination of many smaller changes that
have gone in to enable this change.
- #18829
- #19400
 - #19246
 - #19517
 - #19518
 - #19590
 - #19634
 - #19802

---------

Co-authored-by: Tony Murphy <[email protected]>
Co-authored-by: Daniel Madrid <[email protected]>
Co-authored-by: jzaffiro <[email protected]>
Co-authored-by: Matt Rakow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds Issues related to distributed data structures area: runtime Runtime related issues base: main PRs targeted against main branch dependencies Pull requests that update a dependency file public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants