Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(test-service-load): use node16 module resolution #20314

Merged
merged 2 commits into from
Mar 26, 2024
Merged

build(test-service-load): use node16 module resolution #20314

merged 2 commits into from
Mar 26, 2024

Conversation

DLehenbauer
Copy link
Contributor

Semi-automatic PR to switch to node16 module resolution

@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Mar 25, 2024
@DLehenbauer DLehenbauer marked this pull request as ready for review March 25, 2024 21:59
sonalideshpandemsft
sonalideshpandemsft approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@sonalideshpandemsft sonalideshpandemsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@DLehenbauer DLehenbauer merged commit 9eaca12 into main Mar 26, 2024
31 checks passed
@DLehenbauer DLehenbauer deleted the test-service-load branch March 26, 2024 16:09
tianzhu007 added a commit that referenced this pull request Mar 26, 2024
@tianzhu007
Merge branch 'main' into test/tianzhu/add-ip-type2
910a366 
* main:
  fix(example-utils): Use correct return type on getter (#20334)
  server: fix mutable quorum snapshot (#20329)
  Configurable retry delays in R11s Redis constructors (#20328)
  fix: Do not attempt to hydrate ST proxies in initial tree (#20326)
  test(compressor): Reenable skipped compressor end-to-end tests (#20272)
  build(test-service-load): use node16 module resolution (#20314)
  Framework to disallow old runtimes to open files with explicit document schema control (#20297)
  Clean up extra properties in sending op pipeline that are not needed. (#20295)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalideshpandemsft sonalideshpandemsft sonalideshpandemsft approved these changes

@tylerbutler tylerbutler tylerbutler approved these changes

Assignees
No one assigned
Labels
area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DLehenbauer @tylerbutler @sonalideshpandemsft