-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for stable telemetry #20648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tylerbutler recently posted about binary files in the repo. Do we want to leverage git-lfs again for things like these? In this case since they're going into the public docs site, I think they must go in the repo (vs the wiki or some other place).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not commit binary files to the repo. If we need images we can upload them to our CDN and reference them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tylerbutler @alexvy86 updated PR to use CDN for image assets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content here is good, the comment below is a bit more a "meta" concern.
@@ -0,0 +1,326 @@ | |||
--- | |||
title: Typed telemetry | |||
menuPosition: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might make sense to make this #2 and the existing telemetry one #3, but I need to chew on it more. Might also consider a bit of updating the existing one. There's good content there, but I think it might be confusing to have both articles especially if that one doesn't say something along the lines of "this is for Fluid's internal telemetry which is subject to change", and a reworded title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to have it than not, whatever we decide on the other telemetry one, so approving.
Description
Added fluidframework.com documentation for stable telemetry.
This PR will be merged after rc-3 release.