[RC3] GC: Port recent telemetry changes #20787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are used. (microsoft#20354) Three changes here: 1. Include the full requested path as the id (not trimming to the DataStore) 2. If a node is requested in the same session it was deleted from, log the pkg path 3. Include a specific header value on the 404 response for deleted nodes This will help confirm or refute some assumptions we're making in current investigations, and potentially fill in some gaps.
We have received reports that some documents with tens of thousands of unreferenced nodes take over a second for GC to initialize upon connecting. We need to understand how often this is happening and what the distribution of unreferenced node counts v. duration is like.
…microsoft#20725) Key logic changes: * GC's `nodeUpdated` function only accepts Blob or DataStore paths (no subDataStore). * This is because subDataStore paths may not be tracked/understood by GC. So we use the DataStore path to check Tombstone/Inactive status. * Note that the original subDataStore path is available for logging since the original `request` is passed in * `GCTelemetryTracker.nodeUsed` takes in a `trackedId` param, separate from the props. * `trackedId` would be the DataStore ID in a SubDataStore case * It's used to look up the UnreferencedNodeStateTracker There is some cleanup type stuff in the diff as well, in the areas I was working. Very light refactoring and comments mostly. I added tests to request inactive or Tombstoned SubDataStore paths, and checked the logs to see that we get the logs we are currently missing in these cases.
agarwal-navin
approved these changes
Apr 22, 2024
⯅ @fluid-example/bundle-size-tests: +4.29 KB
Baseline commit: 75a9de2 |
markfields
merged commit 811dcc8
into
microsoft:release/client/2.0.0-rc.3.0
27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the following commits to RC3 branch: