Offline: Minor refactoring of stashedOps.spec.ts #21052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: loader
markfields
commented
May 10, 2024
packages/test/test-end-to-end-tests/src/test/stashedOps.spec.ts
Outdated
Show resolved
Hide resolved
⯅ @fluid-example/bundle-size-tests: +336 Bytes
Baseline commit: 32274f6 |
anthony-murphy
approved these changes
May 15, 2024
kekachmar
pushed a commit
to kekachmar/FluidFramework
that referenced
this pull request
May 21, 2024
Reading through stashedOps.spec.ts, I wanted to make a couple changes: * Move helpers out of the top-level `describe` block, because they were inconsistently using both "global" state from that scope and objects passed in via parameters * Moved `waitForSummary` helper out too, so callsites are explicit about which container is being awaited * I added comments and tweaked some names/strings in the test `handles stashed ops created on top of sequenced local ops` after stepping through it, it was a very interesting one to follow in terms of learning. Bonus change: Move event-specific logging props into the "details" property. It's easier to find this info that way (you don't have to remember the exact name), and avoids an explosion of columns when the telemetry sink turns each prop into its own column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reading through stashedOps.spec.ts, I wanted to make a couple changes:
describeblock, because they were inconsistently using both "global" state from that scope and objects passed in via parameterswaitForSummaryhelper out too, so callsites are explicit about which container is being awaitedgetPendingOpscallsites all changed indentation of the callback, hopefully ignoring whitespace will help in the diffhandles stashed ops created on top of sequenced local opsafter stepping through it, it was a very interesting one to follow in terms of learning.Bonus change: Move event-specific logging props into the "details" property. It's easier to find this info that way (you don't have to remember the exact name), and avoids an explosion of columns when the telemetry sink turns each prop into its own column.
Reviewer Guidance
The logging change should be the only functional change here.