refactor(getKeys): Upgrade eslint config to "recommended" and fix violations in code #21078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvy86
approved these changes
May 14, 2024
kekachmar
pushed a commit
to kekachmar/FluidFramework
that referenced
this pull request
May 21, 2024
…lations in code (microsoft#21078) This package was using the `minimal-deprecated` configuration, which is scheduled for deletion. Upgrades the package's config to the `recommended` base and fixes violations in the code. This PR disables some of the `recommended` rules that are TypeScript-specific. Longer term, we should create a better pattern for JavaScript packages. For now, the primary goal here is to remove usages of the deprecated config. AB#8051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package was using the
minimal-deprecatedconfiguration, which is scheduled for deletion. Upgrades the package's config to therecommendedbase and fixes violations in the code.This PR disables some of the
recommendedrules that are TypeScript-specific. Longer term, we should create a better pattern for JavaScript packages. For now, the primary goal here is to remove usages of the deprecated config.AB#8051