-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service load test] Force some connections to be write mode for Tinylicious #21136
Merged
kian-thompson
merged 2 commits into
microsoft:main
from
kian-thompson:7819-force-some-write-connection
May 17, 2024
Merged
[Service load test] Force some connections to be write mode for Tinylicious #21136
kian-thompson
merged 2 commits into
microsoft:main
from
kian-thompson:7819-force-some-write-connection
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: tests
Tests to add, test infrastructure improvements, etc
base: main
PRs targeted against main branch
labels
May 16, 2024
anthony-murphy
approved these changes
May 17, 2024
kekachmar
pushed a commit
to kekachmar/FluidFramework
that referenced
this pull request
May 21, 2024
…icious (microsoft#21136) We are seeing a large number of "OpRoundtripTime" errors for Tinylicious runs, largely caused by replaying ops at the beginning of the run. Forcing some of these 120 clients to be in write mode from the start should help alleviate some of the load. After this change is merged, I will be monitoring the CI runs to see if the error rate improves. If not, I'll revert this change. [AB#7819](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/7819)
kian-thompson
added a commit
to kian-thompson/FluidFramework
that referenced
this pull request
May 21, 2024
…icious (microsoft#21136) We are seeing a large number of "OpRoundtripTime" errors for Tinylicious runs, largely caused by replaying ops at the beginning of the run. Forcing some of these 120 clients to be in write mode from the start should help alleviate some of the load. After this change is merged, I will be monitoring the CI runs to see if the error rate improves. If not, I'll revert this change. [AB#7819](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/7819)
kian-thompson
added a commit
to kian-thompson/FluidFramework
that referenced
this pull request
May 21, 2024
…icious (microsoft#21136) We are seeing a large number of "OpRoundtripTime" errors for Tinylicious runs, largely caused by replaying ops at the beginning of the run. Forcing some of these 120 clients to be in write mode from the start should help alleviate some of the load. After this change is merged, I will be monitoring the CI runs to see if the error rate improves. If not, I'll revert this change. [AB#7819](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/7819)
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: tests
Tests to add, test infrastructure improvements, etc
base: main
PRs targeted against main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing a large number of "OpRoundtripTime" errors for Tinylicious runs, largely caused by replaying ops at the beginning of the run. Forcing some of these 120 clients to be in write mode from the start should help alleviate some of the load.
After this change is merged, I will be monitoring the CI runs to see if the error rate improves. If not, I'll revert this change.
AB#7819