Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify IDisposable interfaces #21184

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Conversation

CraigMacomber
Copy link
Contributor

Description

Unify IDisposable interfaces from @fluidframework/tree and @fluidframework/core-interfaces.

Breaking Changes

Public APIs in @fluidframework/tree now use IDisposable from @fluidframework/core-interfaces replacing disposeSymbol with "dispose".

IDisposable in @fluidframework/core-interfaces is now @sealed indicating that third parties should not implement it to reserve the ability for Fluid Framework to extend it to include Symbol.dispose as a future non-breaking change.

Reviewer Guidance

The review process is outlined on this wiki page.

@CraigMacomber CraigMacomber requested a review from a team as a code owner May 21, 2024 19:38
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API base: main PRs targeted against main branch labels May 21, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented May 21, 2024

@fluid-example/bundle-size-tests: -28 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 453.27 KB 453.27 KB No change
azureClient.js 552.5 KB 552.5 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 256.97 KB 256.97 KB No change
fluidFramework.js 360.48 KB 360.47 KB -14 Bytes
loader.js 134.38 KB 134.38 KB No change
map.js 41.46 KB 41.46 KB No change
matrix.js 143.75 KB 143.75 KB No change
odspClient.js 520.87 KB 520.87 KB No change
odspDriver.js 97.3 KB 97.3 KB No change
odspPrefetchSnapshot.js 42.16 KB 42.16 KB No change
sharedString.js 160.27 KB 160.27 KB No change
sharedTree.js 360.46 KB 360.45 KB -14 Bytes
Total Size 3.2 MB 3.2 MB -28 Bytes

Baseline commit: e532541

Generated by 🚫 dangerJS against 96dedbb

@CraigMacomber CraigMacomber merged commit cfcb827 into microsoft:main Jun 3, 2024
30 checks passed
@CraigMacomber CraigMacomber deleted the dispose branch June 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants