Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TreeStatus.Created and tighten transaction APIs #21270

Merged
merged 1 commit into from
May 31, 2024

Conversation

noencke
Copy link
Contributor

@noencke noencke commented May 31, 2024

BREAKING CHANGE: A new tree status has been added for SharedTree nodes.

TreeStatus.Created indicates that a SharedTree node has been constructed but not yet inserted into the tree.
Constraints passed to the runTransaction API are now marked as readonly.

@noencke noencke requested a review from yann-achard-MS May 31, 2024 23:02
@noencke noencke requested a review from a team as a code owner May 31, 2024 23:02
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct public api change Changes to a public API base: main PRs targeted against main branch labels May 31, 2024
@yann-achard-MS
Copy link
Contributor

This PR should be described as breaking change (and never be cherry-picked into earlier RCs)

@yann-achard-MS
Copy link
Contributor

Is there are reason why this PR includes the readonly-fication changes at the same time as the introduction of the "Created" status?

@noencke
Copy link
Contributor Author

noencke commented May 31, 2024

Is there are reason why this PR includes the readonly-fication changes at the same time as the introduction of the "Created" status?

There's no particular reason.

@yann-achard-MS
Copy link
Contributor

Is there are reason why this PR includes the readonly-fication changes at the same time as the introduction of the "Created" status?

There's no particular reason.

Okay, that's a little weird but the changes are simple enough that it doesn't bother me.

@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +30 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 453.27 KB 453.27 KB No change
azureClient.js 552.5 KB 552.5 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 256.97 KB 256.97 KB No change
fluidFramework.js 360.46 KB 360.48 KB +15 Bytes
loader.js 134.38 KB 134.38 KB No change
map.js 41.46 KB 41.46 KB No change
matrix.js 143.75 KB 143.75 KB No change
odspClient.js 520.87 KB 520.87 KB No change
odspDriver.js 97.3 KB 97.3 KB No change
odspPrefetchSnapshot.js 42.16 KB 42.16 KB No change
sharedString.js 160.27 KB 160.27 KB No change
sharedTree.js 360.45 KB 360.46 KB +15 Bytes
Total Size 3.2 MB 3.2 MB +30 Bytes

Baseline commit: 9bf98f0

Generated by 🚫 dangerJS against 451c485

@noencke noencke merged commit 8760e32 into microsoft:main May 31, 2024
32 checks passed
@noencke noencke deleted the created-status branch May 31, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants