(tree): remove internal tree types from public export #21330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
ChumpChief
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
I think this looks reasonable - @CraigMacomber can you please also sign off since this is based on your feedback?
github-actions
bot
removed
the
dependencies
CraigMacomber
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference for list of API Issues:
https://github.com/microsoft/FluidFramework/pull/19724/files
Some of the tree types in the current public export involve type manipulation which shouldn't be exposed. These types are mainly used by other exported APIs, so they are now exported from an internal types module instead.