[main>rc5] ci: fix build-tools installation in GH actions workflow #21593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) This workflow was not updated after build-tools was updated to ESM instead of CJS. The fix is to use `npm link` to make `flub` available since the old shim was removed when we switched to ESM. Tested with [act](https://github.com/nektos/act): ``` act push -W .github/workflows/push-tag-create-release.yml -v ``` [AB#8474](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/8474)
markfields
approved these changes
Jun 22, 2024
tylerbutler
merged commit 786b7d0
into
microsoft:release/client/2.0.0-rc.5.0
25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #21556 from main to RC5.
This workflow was not updated after build-tools was updated to ESM instead of CJS. The fix is to use
npm linkto makeflubavailable since the old shim was removed when we switched to ESM.Tested with act: