[main>rc5] fix(version-tools): Fix comparison of 2.0 releases to RC builds #21655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osoft#21641) With the 2.0.0 release, we now have semver releases that are compared with RC and internal build numbers. I have fixed the logic in version-tools to correctly treat RC -> 2.0 as a major bump. I also updated the generate:buildVersion command to use the list of tags passed in for all logic. There was some code that checked for existing tags and it always used the in-repo tag list. Now, if a list of tags is passed in, it is used for all logic. The repo tags are only consulted when none are passed in.
pragya91
approved these changes
Jun 27, 2024
tylerbutler
merged commit b116899
into
microsoft:release/client/2.0.0-rc.5.0
26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #21641 to RC5.
With the 2.0.0 release, we now have semver releases that are compared with RC and internal build numbers. I have fixed the logic in version-tools to correctly treat RC -> 2.0 as a major bump.
I also updated the generate:buildVersion command to use the list of tags passed in for all logic. There was some code that checked for existing tags and it always used the in-repo tag list. Now, if a list of tags is passed in, it is used for all logic. The repo tags are only consulted when none are passed in.