Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve changesets for tree errors #21940

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

CraigMacomber
Copy link
Contributor

Description

Improve/add error related changesets for tree.

Reviewer Guidance

The review process is outlined on this wiki page.

@CraigMacomber CraigMacomber requested a review from a team as a code owner July 18, 2024 17:03
@github-actions github-actions bot added the base: main PRs targeted against main branch label Jul 18, 2024
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of typos. I know adding new changeset files at this point has some caveats, like they don't end up linked to the right commit. Did we have to do anything about that @tylerbutler ?

.changeset/weak-swans-take.md Outdated Show resolved Hide resolved
@tylerbutler
Copy link
Member

Just a couple of typos. I know adding new changeset files at this point has some caveats, like they don't end up linked to the right commit. Did we have to do anything about that @tylerbutler ?

The entries in the per-package changelogs will link to this PR/commit, which isn't ideal but it's the best we can do atm. If there is a better PR to link to, my preferred pattern is to include a sentence at the end of the changeset like, "This change was originally made in PR 1234."

@CraigMacomber
Copy link
Contributor Author

The entries in the per-package changelogs will link to this PR/commit, which isn't ideal but it's the best we can do atm. If there is a better PR to link to, my preferred pattern is to include a sentence at the end of the changeset like, "This change was originally made in PR 1234."

Done.

@CraigMacomber CraigMacomber merged commit 3b8a366 into microsoft:main Jul 18, 2024
26 checks passed
@CraigMacomber CraigMacomber deleted the treeChange branch July 18, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants